Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for invalid config file options #930

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Brief summary of changes if not sufficiently described by commit messages.

⚙️ Test Data and/or Report

Not automated test. New output when there is an unknown keyword in configuration file is:

validate -c config.txt -t something
org.apache.commons.configuration.ConfigurationException: Unrecognized keyword(s) in config file: bad.keyword

♻️ Related Issues

Closes #923

@al-niessner al-niessner self-assigned this Jun 10, 2024
@al-niessner al-niessner requested a review from a team as a code owner June 10, 2024 19:19
@al-niessner
Copy link
Contributor Author

@jordanpadams @nutjob4life

Can safely ignore JAXA error in auto tests. Just simple code change here.

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not requesting changes so much as requesting "reflection" on my comment above 😁

@jordanpadams
Copy link
Member

Branch testing re-run successful: https://github.com/NASA-PDS/validate/actions/runs/9487729408

@jordanpadams jordanpadams changed the title 923: throw error for unknowns Improve error handling for invalid config file options Jun 12, 2024
@jordanpadams jordanpadams merged commit cada831 into main Jun 12, 2024
3 of 5 checks passed
@jordanpadams jordanpadams deleted the issue_923 branch June 12, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration file parser does not reject incorrect options
3 participants