Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cucumber dependencies #985

Merged
merged 7 commits into from
Aug 29, 2024
Merged

Upgrade cucumber dependencies #985

merged 7 commits into from
Aug 29, 2024

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Adjust code to new artifiacts.

⚙️ Test Data and/or Report

See automated unit/regression tests below

♻️ Related Issues

Closes #972
Closes #974

dependabot bot and others added 4 commits August 19, 2024 14:03
Bumps com.sun.xml.bind:jaxb-impl from 2.3.4 to 3.0.2.

---
updated-dependencies:
- dependency-name: com.sun.xml.bind:jaxb-impl
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [io.cucumber:cucumber-java](https://github.com/cucumber/cucumber-jvm) from 6.9.1 to 7.18.1.
- [Release notes](https://github.com/cucumber/cucumber-jvm/releases)
- [Changelog](https://github.com/cucumber/cucumber-jvm/blob/main/CHANGELOG.md)
- [Commits](cucumber/cucumber-jvm@v6.9.1...v7.18.1)

---
updated-dependencies:
- dependency-name: io.cucumber:cucumber-java
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@al-niessner al-niessner self-assigned this Aug 29, 2024
@al-niessner al-niessner requested a review from a team as a code owner August 29, 2024 17:19
The changes from there to bigger than 2x is significant. The interesting part is how sporadic the errors are. The bottom line is this:

Caused by: java.lang.ClassNotFoundException: com.sun.xml.internal.bind.v2.ContextFactory
	at java.base/java.lang.ClassLoader.findClass(ClassLoader.java:723)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
	at javax.xml.bind.ServiceLoaderUtil.nullSafeLoadClass(ServiceLoaderUtil.java:122)
	at javax.xml.bind.ServiceLoaderUtil.safeLoadClass(ServiceLoaderUtil.java:155)
	at javax.xml.bind.ContextFinder.newInstance(ContextFinder.java:276)

It seems that some configuration or help needs to be given to fill in the now missing class. Pulling back this change because its use is limited and thus its real security risk is minimal. The files it reads are provided by the user and thus trusted.
@jordanpadams jordanpadams merged commit 0b41d82 into main Aug 29, 2024
3 checks passed
@jordanpadams jordanpadams deleted the bump branch August 29, 2024 18:56
@jordanpadams jordanpadams changed the title Bump Upgrade cucumber dependencies Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants