Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create F2_13.c #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create F2_13.c #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions F2_13.c
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we modularize the logic for checking buffer overflow and adding the fractional part to avoid redundancy?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pros:
The clear structure and modularity of the code make it easy to extend or modify for future requirements, such as supporting different numeric formats or additional arithmetic operations.
The use of integer arithmetic allows for potential optimizations specific to the target hardware, such as using fixed-point arithmetic for better performance.
The implementation includes basic error checking and validation, reducing the risk of runtime errors.

Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
void intToString(int num, char result[], int* pos) {
if (num == 0) {
result[(*pos)++] = '0';
return;
}

int digits[10];
int count = 0;
if (num < 0) {
result[(*pos)++] = '-';
num = -num;
}
while (num > 0) {
digits[count++] = num % 10;
num /= 10;
}
for (int i = count - 1; i >= 0; i--) {
result[(*pos)++] = '0' + digits[i];
}
}

int add(int c1, int n1, int d1, int c2, int n2, int d2, char result[], int len) {
int commonDenominator = d1 * d2;
int numeratorSum = n1 * d2 + n2 * d1;
int characteristicSum = c1 + c2 + numeratorSum / commonDenominator;
numeratorSum %= commonDenominator;

int pos = 0;
intToString(characteristicSum, result, &pos);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test the functions with negative inputs to ensure they work as expected?


result[pos++] = '.';

if (numeratorSum == 0) {
result[pos++] = '0';
} else {
int divisor = commonDenominator / 10;
while (divisor > 0 && numeratorSum / divisor == 0) {
result[pos++] = '0';
divisor /= 10;
}
while (divisor > 0) {
result[pos++] = '0' + numeratorSum / divisor;
numeratorSum %= divisor;
divisor /= 10;
}
}

result[pos] = '\0';
return 1;
}

int subtract(int c1, int n1, int d1, int c2, int n2, int d2, char result[], int len) {
int commonDenominator = d1 * d2;
int numeratorDiff = n1 * d2 - n2 * d1;
int characteristicDiff = c1 - c2 + numeratorDiff / commonDenominator;
numeratorDiff %= commonDenominator;

int pos = 0;
intToString(characteristicDiff, result, &pos);

result[pos++] = '.';

if (numeratorDiff == 0) {
result[pos++] = '0';
} else {
int divisor = commonDenominator / 10;
while (divisor > 0 && numeratorDiff / divisor == 0) {
result[pos++] = '0';
divisor /= 10;
}
while (divisor > 0) {
result[pos++] = '0' + numeratorDiff / divisor;
numeratorDiff %= divisor;
divisor /= 10;
}
}

result[pos] = '\0';
return 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more comprehensive error messages for different failure scenarios?

}