Create F2_16.c #16
Open
Create F2_16.c #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application you will be writing for is intended to run on a small, inexpensive embedded device that does not have a floating point unit. This means that the processor can only do integer arithmetic. However, the device does have a display and needs to display the result of floating point arithmetic to the user. Because this is a small inexpensive processor there is no support for strings or any mathematical library functions. You must write all the code yourselves performing all the floating point math with integers only and no strings! Character arrays, or C strings, can't tell you their size but they do end with a '\0' character.
The requirements for the code are to write one of the functions presented below. All the functions return a boolean value indicating the success or failure of the operation. Improper data is the most likely cause for a function to fail. You may add your own additional helper functions (I had at least a half dozen) but you must include them for the review. Do not change the interface to these functions.
These two functions take as parameters two sets of mantissa and characteristic and a char array to hold the result of the arithmetic operations. The result of the add or subtract should be converted into char's and placed in the result array. The array must end with a '\0'. The 'len' parameter tells how many characters can be placed on the result array. For these functions to return true you must at a minimum store the characteristic of the result. If the result is a non-integer place as many of the digits as will fit in the result after a decimal point.
```c
bool add(int c1, int n1, int d1, int c2, int n2, int d2, char result[], int len);
bool subtract(int c1, int n1, int d1, int c2, int n2, int d2, char result[], int len);
...
...
char answer[100];
int c1, n1, d1;
int c2, n2, d2;
c1 = 1;
n1 = 1;
d1 = 2;
c2 = 2;
n2 = 2;
d2 = 3;
//if the C string could hold at least the characteristic if(add(c1, n1, d1, c2, n2, d2, answer, 100))
{
//display string with answer 4.166666666...
}
else
{
//display error message
}
'''
|
I am Working on this pull request |
sai-chand04
reviewed
Jun 18, 2024
| int subtract(int c1, int n1, int d1, int c2, int n2, int d2, char result[], int len) { | ||
| int commonDenominator = d1 * d2; | ||
| int numeratorDiff = n1 * d2 - n2 * d1; | ||
| int characteristicDiff = c1 - c2 + numeratorDiff / commonDenominator; |
There was a problem hiding this comment.
Can we add a check to make sure that the commonDenominator not zero by using the if-else conditional statement.
| int add(int c1, int n1, int d1, int c2, int n2, int d2, char result[], int len) { | ||
| int commonDenominator = d1 * d2; | ||
| int numeratorSum = n1 * d2 + n2 * d1; | ||
| int characteristicSum = c1 + c2 + numeratorSum / commonDenominator; |
There was a problem hiding this comment.
Can we add a check to make sure that the commonDenominator not zero by using the if-else conditional statement.
There was a problem hiding this comment.
Can we add the comments for the code for better readability and the maintainability.
Comment on lines
+28
to
+49
| int pos = 0; | ||
| intToString(characteristicSum, result, &pos); | ||
|
|
||
| result[pos++] = '.'; | ||
|
|
||
| if (numeratorSum == 0) { | ||
| result[pos++] = '0'; | ||
| } else { | ||
| int divisor = commonDenominator / 10; | ||
| while (divisor > 0 && numeratorSum / divisor == 0) { | ||
| result[pos++] = '0'; | ||
| divisor /= 10; | ||
| } | ||
| while (divisor > 0) { | ||
| result[pos++] = '0' + numeratorSum / divisor; | ||
| numeratorSum %= divisor; | ||
| divisor /= 10; | ||
| } | ||
| } | ||
|
|
||
| result[pos] = '\0'; | ||
| return 1; |
There was a problem hiding this comment.
Can we move this piece of code to the new function to avoid duplication.
Comment on lines
+58
to
+79
| int pos = 0; | ||
| intToString(characteristicDiff, result, &pos); | ||
|
|
||
| result[pos++] = '.'; | ||
|
|
||
| if (numeratorDiff == 0) { | ||
| result[pos++] = '0'; | ||
| } else { | ||
| int divisor = commonDenominator / 10; | ||
| while (divisor > 0 && numeratorDiff / divisor == 0) { | ||
| result[pos++] = '0'; | ||
| divisor /= 10; | ||
| } | ||
| while (divisor > 0) { | ||
| result[pos++] = '0' + numeratorDiff / divisor; | ||
| numeratorDiff %= divisor; | ||
| divisor /= 10; | ||
| } | ||
| } | ||
|
|
||
| result[pos] = '\0'; | ||
| return 1; |
There was a problem hiding this comment.
Can we replace this piece of code with the newly created function ( which we created for removing the duplicate code in the add function)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application you will be writing for is intended to run on a small, inexpensive embedded device that does not have a floating point unit. This means that the processor can only do integer arithmetic. However, the device does have a display and needs to display the result of floating point arithmetic to the user. Because this is a small inexpensive processor there is no support for strings or any mathematical library functions. You must write all the code yourselves performing all the floating point math with integers only and no strings! Character arrays, or C strings, can't tell you their size but they do end with a '\0' character.
The requirements for the code are to write one of the functions presented below. All the functions return a boolean value indicating the success or failure of the operation. Improper data is the most likely cause for a function to fail. You may add your own additional helper functions (I had at least a half dozen) but you must include them for the review. Do not change the interface to these functions.
These two functions take as parameters two sets of mantissa and characteristic and a char array to hold the result of the arithmetic operations. The result of the add or subtract should be converted into char's and placed in the result array. The array must end with a '\0'. The 'len' parameter tells how many characters can be placed on the result array. For these functions to return true you must at a minimum store the characteristic of the result. If the result is a non-integer place as many of the digits as will fit in the result after a decimal point.