Add time series plots #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean up amwg tables for derived quantities and move RESTOM to top of table
- Block out missing seasons on website
- Fix error if missing mclim_fils in regrid_and_vert_interp
* part of Issue 228
nusbaume
added
enhancement
nusbaume
requested changes
Mar 9, 2023
There was a problem hiding this comment.
Mostly looks good, except it doesn't appear that timeseries_var_list is actually defined anywhere in the ADF object, at least in this PR. Maybe there is a local commit somewhere that still needs to be pushed?
Otherwise mostly just a bunch of small change requests and slight feature expansions. As always let me know if you have any questions or concerns with any of my requests. Thanks!
This was referenced Mar 24, 2023
|
Closing due to updated PR coming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add time series plots to scripts directory and will have the option in the config yaml file to plot only certain variables, as opposed to all declared in
diag_var_listThe time series variables get declared in
timeseries_var_listand must also be indiag_var_list. It's not ideal and has some redundancy, but this can be addressed in the future if desired.timeseries_var_listw/o its constituents so long as they (FSNT and FLNT) are in thediag_var_list.It is also set up to plot any derived quantity, the user just needs to create functions to do so. The RESTOM calculation can be used a rough guide.
The script also looks at any variable with vertical levels and ignores it (similar to AMWG tables). In the future it might be nice to have an option to plot variables with vertical levels if single levels are designated, but currently it just skips them.
The time series also calculates seasonally weighted averages based on month length.
There is also a flag in
adf_variable_defaults.yamlto set a rolling 5-year mean. Currently RESTOM is defaulted to this, but can be changed.In addition, some minor cleanup included:
adf_variable_defaults.yaml* Part of Issue 228