Adf Percent Change Plot Panels #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 'transform_first=True' to img3 contourf calls to prevent random polygon errors.
|
Made a few additional fixes to plotting_functions.py to get the checks to pass. |
justin-richling
requested changes
Nov 11, 2024
There was a problem hiding this comment.
@shawnusaf This all looks good, sorry for all the comments about commented code, if you could just go through and remove those lines I think we are good to merge this in!
Removed 2 commented out percent change lines containing old code.
Removed old percent change calcluations that were commented out.
Removed commented out lines of code that didn't need to be there any longer.
|
I think I should have all of the commented lines removed. |
justin-richling
approved these changes
Nov 12, 2024
|
@shawnusaf Thanks for the updates, this is now merged in. |
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request adds/addresses the following:
Item 1 addresses #331.
-Shawn