Update glob for variables with underscore #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue with the wildcard in globbing regridded files that would cause issues if two variable names were similar but one had an underscore, if vpwp_mfl and vpwp.
|
@brianpm I think this fix will address the problem of variables with underscores. It worked on the test cases Ben sent me. Can you just take a quick look and see if I might be missing any unintended consequences? |
|
Yeah, that does seem good! I sent you an alternative using a regex, but this seems nice and simple. Maybe we should have Ben test it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the wildcard in globbing regridded files that would cause issues if two variable names were similar but one had an underscore, ie vpwp_mfl and vpwp.