capture QC changes if posterior FOs skipped

[nancycollins]

capture QC changes from the main assimilation loop if posterior FOs skipped

if the posterior forward operator code is skipped, any changes to the DART QC in the main assimilation loop (currently only setting QC=8 for failed vertical conversions) will be lost. this update captures the changed QCs so they are written to the output obs_seq.final file.

Description:

If posterior FOs are not being computed, this code change makes the filter loop call a new subroutine instead of the obs_space_diagnostics() routine, which only collects the QCs and adds them to the output obs_seq.

Fixes issue

fixes bug #401

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Documentation changes needed?

• My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Checklist for merging

• Updated changelog entry
• Documentation updated
• Update conf.py

Checklist for release

• Merge into main
• Create release from the main branch with appropriate tag
• Delete feature-branch

Testing Datasets

• Dataset needed for testing available upon request
• Dataset download instructions included
• No dataset needed

[hkershaw-brown]

Marlee looking at qc when
distributed_state=.false.

[mjs2369]

The content of this PR will be released in a different PR that includes all bug-fixes relating to the QC8 issue.