Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused routine from normal_distribution_mod.f90 #763

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

hkershaw-brown
Copy link
Member

Description:

Removed unused routine from normal_distribution_mod.f90
Why?

  • we've had a couple of users be tripped up on this warning #6843 while troubleshooting other problems
  • broken windows, innit?

Fixes issue

fixes #736

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Build everything in DART on "unused-routine" branch:
https://github.com/NCAR/DART/actions/runs/11613730959

note the GOES build fails because the container is linking to rttov12 not rttov13 (NCAR/DART-containers#1).

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown added the release+1 bundle with release after next label Nov 6, 2024
Copy link
Contributor

@mjs2369 mjs2369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean removal

@hkershaw-brown hkershaw-brown added release! bundle with next release and removed release+1 bundle with release after next labels Nov 7, 2024
@hkershaw-brown hkershaw-brown merged commit 4a0389a into main Nov 8, 2024
4 checks passed
@hkershaw-brown hkershaw-brown deleted the unused-routine branch November 8, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

note on normal distribution inv_cdf_quadrature_like X_OUT
2 participants