Fix bugs in Leith add new input parameter #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a few bugs in MOM_hor_visc when using Leith and Modified_Leith.These are: 1) deletes unecessary call to pass_var; 2) changes the j indices to loop over when computing divergence gradient (div_xx_d?) and its magnitude (grad_div_mag_?) A runtime parameter (ADD_LES_VISCOSITY) to control if the viscosity from Smagorinsky and Leith should be added to the background value, rather than taking the maximum value, has also been added.
Codecov Report
@@ Coverage Diff @@
## dev/ncar #134 +/- ##
============================================
+ Coverage 43.17% 43.17% +<.01%
============================================
Files 213 213
Lines 62233 62234 +1
============================================
+ Hits 26866 26869 +3
+ Misses 35367 35365 -2
Continue to review full report at Codecov.
|
|
Nuopc runs are failing. See for example: /glade/scratch/altuntas/cesm.tests/cheyenne/aux_mom/191120/SMS_Vnuopc.T62_t061.GMOM.cheyenne_intel.C.20191211_120721_xdtof1 Will look into it. |
alperaltuntas
approved these changes
Dec 12, 2019
alperaltuntas
pushed a commit
that referenced
this pull request
Aug 9, 2024
update to main 20240508 commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs in MOM_hor_visc when using Leith and
Modified_Leith.These are:
(div_xx_d?) and its magnitude (grad_div_mag_?)
A runtime parameter (ADD_LES_VISCOSITY) to control if the viscosity from
Smagorinsky and Leith should be added to the background value, rather
then taking the maximum value, has also been added.
Thanks to @septicscuzzy for making these changes.
This PR should not change answers for NCAR since these schemes are
currently not enabled.