De-allocate Kd_bkgnd and Kv_bkgnd #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These arrays were not being deallocated which was causing a memory leak problem.
alperaltuntas
approved these changes
May 23, 2021
|
Just to let you know that I am working through our memory allocations as well, see this branch: https://github.com/marshallward/mom6/tree/valgrind_fixes You can push changes over there as well if you want to keep in sync. |
alperaltuntas
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Change dumbbell initialization * Change in Dumbbell Layer Mode * Fix sponge diagnostics * Fix ALE Sponge Diagnostics * A minor style change removing spaces around = in optional. function arguments. * Fix ALE sponge diagnostics * character declaration fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Kd_bkgnd or Kv_bkgnd are included in the diag_table, a corresponding 3D array gets allocated every tracer time step so the requested diagnostic can be posted. However, this array was never deallocated which caused a memory leak. This patch fixes this issue by making sure both Kd_bkgnd or Kv_bkgnd are deallocated.
Many thanks to @klindsay28 for helping to find this memory leak.
This PR should not change answers.