Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensional Consistency fixes #209

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Dimensional Consistency fixes #209

merged 3 commits into from
Feb 15, 2022

Conversation

alperaltuntas
Copy link
Member

Misc DIMCS fixes from @klindsay28. With these changes all DIMCS tests pass.

@alperaltuntas
Copy link
Member Author

This should be squashed and merged once the github actions tests pass.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #209 (6f9fa06) into dev/ncar (e55df40) will increase coverage by 0.99%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/ncar     #209      +/-   ##
============================================
+ Coverage     28.99%   29.98%   +0.99%     
============================================
  Files           237      239       +2     
  Lines         71905    73980    +2075     
============================================
+ Hits          20847    22183    +1336     
- Misses        51058    51797     +739     
Impacted Files Coverage Δ
src/parameterizations/lateral/MOM_MEKE.F90 50.51% <0.00%> (ø)
src/ALE/MOM_regridding.F90 21.51% <66.66%> (+0.06%) ⬆️
src/framework/MOM_diag_remap.F90 79.57% <100.00%> (ø)
...c/parameterizations/stochastic/MOM_stochastics.F90 52.27% <0.00%> (ø)
...external/stochastic_physics/stochastic_physics.F90 0.00% <0.00%> (ø)
src/core/MOM.F90 64.12% <0.00%> (+5.34%) ⬆️
...c/parameterizations/vertical/MOM_energetic_PBL.F90 51.67% <0.00%> (+6.06%) ⬆️
...parameterizations/vertical/MOM_diabatic_driver.F90 45.60% <0.00%> (+6.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55df40...6f9fa06. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants