-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accommodate multi-instance runs in CESM #241
Conversation
…he coupler (alternative to FMS ensemble mngr)
…ti-instance CESM runs
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev/ncar #241 +/- ##
============================================
+ Coverage 35.88% 37.18% +1.30%
============================================
Files 260 263 +3
Lines 72088 73207 +1119
Branches 13601 13621 +20
============================================
+ Hits 25868 27223 +1355
+ Misses 41171 40976 -195
+ Partials 5049 5008 -41
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
The changes to MOM and the FMS infra should be fine. I have a pending PR which removes the references to (I would suggest looking into squashing and rebasing some of these commits though!) |
I ran an 8 instance case with this, looks good. |
@gustavo-marques , I just realized there is a conflict due to the latest PR merge. I'll address that. |
@gustavo-marques this is ready to merge. You can squash and merge. To run with multiple instances you can set |
This PR introduces changes that are mainly in NUOPC cap, infra/FMS, and src/framework to accommodate multi-instance runs in CESM:
Changes in nuopc cap:
ensemble_manager_init
. This makes sure the input/output files contain the instance suffix.Changes in infra/FMS{1,2}:
ensumble_suffix
arg toensemble_manager_init
. If provided, this arg bypasses the call toFMS_ensemble_manager_init
, and instead, callsfms_io_set_filename_appendix
andfms2_io_set_filename_appendix
. This makes sure that all i/o files managed my FMS contains the ensemble suffix.Change in src/framework:
This PR should be evaluating in conjunction with ESCOMP/MOM_interface#137.
I am mentioning @MJHarrison-GFDL, @marshallward, and @hkershaw-brown in case they'd prefer to review this PR before it gets merged to dev/ncar. If so, please let us know and will hold off until you review.