Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVR issue with CAM/AdamPhillips #2829

Closed
sgpearse opened this issue Jul 26, 2021 · 7 comments
Closed

DVR issue with CAM/AdamPhillips #2829

sgpearse opened this issue Jul 26, 2021 · 7 comments
Assignees
Labels
Milestone

Comments

@sgpearse
Copy link
Collaborator

sgpearse commented Jul 26, 2021

To reproduce:

  1. Import the following as CF compliant data, on cisl-vapor:

/little_glade/data/Source/CAM/AdamPhillips/v5_rel04_BC5_ne120_t12_pop62/FV_768x1152.bilinear.v5_rel04_BC5_ne120_t12_pop62.cam.h0.0001-01.nc

  1. Create and enable a DVR, and the following behavior can be seen:

Home viewpoint:

Screen Shot 2021-07-26 at 8 54 32 AM

Rotate about the X axis:
Screen Shot 2021-07-26 at 8 55 17 AM

@sgpearse sgpearse added the Bug label Jul 26, 2021
@sgpearse
Copy link
Collaborator Author

@clyne comments:

That may simply be because the ROMS data are uber thin along the Z axis and are missed entirely by the sampling.

@sgpearse
Copy link
Collaborator Author

sgpearse commented Jul 26, 2021

@shaomeng and @StasJ will try scaling it by a lot. Will also test on another machine.

@shaomeng
Copy link
Contributor

If I really understand what "scaling it by a lot" means, I get the following.

image

@StasJ
Copy link
Collaborator

StasJ commented Jul 27, 2021

I renders correctly for me:

ss

@clyne
Copy link
Collaborator

clyne commented Jul 27, 2021

Then ignore my previous comments about the data being too thin and not properly sampled. This looks like a GPU or driver-specific bug. Or, perhaps a regression introduced by #2813. @StasJ have you checked that? If it is a regression I think we either need to fix the current problem, or consider backing out #2813

@StasJ
Copy link
Collaborator

StasJ commented Jul 27, 2021

Then ignore my previous comments about the data being too thin and not properly sampled. This looks like a GPU or driver-specific bug. Or, perhaps a regression introduced by #2813. @StasJ have you checked that? If it is a regression I think we either need to fix the current problem, or consider backing out #2813

Yes, it works correctly with the most recent version of the renderer.

@clyne clyne added this to the 3_5_0 release milestone Jul 27, 2021
@clyne
Copy link
Collaborator

clyne commented Jul 28, 2021

@sgpearse can we close this after @StasJ backs out the changes for #2800?

@sgpearse sgpearse closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants