Fix #2800 ROMS DVR artifacts #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaomeng
approved these changes
Jul 20, 2021
clyne
reviewed
Jul 20, 2021
| break; | ||
| } | ||
| if (t1-t0 <= EPSILON) { |
There was a problem hiding this comment.
Is t1 guaranteed to be greater than t0 (i.e. no need to take absolute value)? Will the comparison with EPSILON work regardless of the user coordinates (it's not clear what coordinate system t0, t1 are in)
There was a problem hiding this comment.
t represents distance along the view ray as in R=o+t*d. This is supposed to test t1 <= t0 rather than t1 == t0.
clyne
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2800 and improve DVR support for non-hexahedral cells.