Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures converting data to VDC format #3046 #3047

Closed
wants to merge 2 commits into from
Closed

Failures converting data to VDC format #3046 #3047

wants to merge 2 commits into from

Conversation

clyne
Copy link
Collaborator

@clyne clyne commented Feb 22, 2022

Fixed #3046

This change prohibits variables from being defined as both coordinate and data variables in the VDC. At present the VDC cannot support this because the underlying NetCDF API doesn't allow a variable to be defined twice.

@clyne clyne requested a review from StasJ February 22, 2022 20:23
Copy link
Collaborator

@StasJ StasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case that a variable is defined as both a coord and data var, this PR appears to only keep whichever is defined last. Wouldn’t this lead to situations where the dataset is missing data or worse missing coordinates? Should we prioritize keeping the coordinate data? We could also rename the data variable to say lat_data in this scenario.

@clyne
Copy link
Collaborator Author

clyne commented Feb 22, 2022

Yes, this is a problem. This issue has become a can of worms, and I'm not really sure what to do about it. I need to think some more. Converting this PR to a draft for now.

@clyne clyne marked this pull request as draft February 22, 2022 21:23
@clyne clyne closed this Feb 23, 2022
@clyne clyne deleted the issue_3046 branch February 23, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures converting data to VDC format
2 participants