Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3440: Moving domain bug #3445

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix #3440: Moving domain bug #3445

merged 1 commit into from
Sep 18, 2023

Conversation

StasJ
Copy link
Collaborator

@StasJ StasJ commented Aug 24, 2023

Fix #3440

@NihanthCW NihanthCW requested a review from sgpearse August 29, 2023 20:36
Copy link
Collaborator

@sgpearse sgpearse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the steps in the bug report, then disable the Volume and Image renderers. The Flow region is incorrect.

Screen Shot 2023-08-29 at 5 12 06 PM

@StasJ
Copy link
Collaborator Author

StasJ commented Sep 1, 2023

Follow the steps in the bug report, then disable the Volume and Image renderers. The Flow region is incorrect.

I get correct results when following your directions:

ss

@sgpearse
Copy link
Collaborator

sgpearse commented Sep 1, 2023

That's really strange. When I load domain.vs3 in the zip file from the bug report, and disable all renderers but flow, something goes awry. I'm definitely on issue3340.

Screen Shot 2023-09-01 at 8 18 04 AM

@StasJ
Copy link
Collaborator Author

StasJ commented Sep 1, 2023

That's really strange. When I load domain.vs3 in the zip file from the bug report, and disable all renderers but flow, something goes awry. I'm definitely on issue3340.

  1. Loading domain.vs3 is not one of the steps in the bug report:

Follow the steps in the bug report, then disable...

  1. That session file was generated using a bug. The bug was fixed, but it does not retroactively repair bad session files, especially since we never released a version containing this bug.

@sgpearse
Copy link
Collaborator

sgpearse commented Sep 1, 2023

That's fair, however when not using the session file I see the following which is the incorrect behavior from my screenshot 3 days ago :(. The domain is too long on the Y axis and the northern region of the flow renderer is truncated.

I'm not sure how we're seeing two different things. Would it be useful to do a screen share?

Screen Shot 2023-09-01 at 8 44 07 AM

@StasJ
Copy link
Collaborator Author

StasJ commented Sep 1, 2023

That's fair, however when not using the session file I see the following which is the incorrect behavior from my screenshot 3 days ago :(. The domain is too long on the Y axis and the northern region of the flow renderer is truncated.

I'm not sure how we're seeing two different things. Would it be useful to do a screen share?

Just a sanity check: Are you using the pre-release installer or building from this branch for your tests?

@sgpearse
Copy link
Collaborator

sgpearse commented Sep 1, 2023

Just a sanity check: Are you using the pre-release installer or building from this branch for your tests?

I'm building on issue3440 in debug mode with all other defaults applied. But I don't think there's urgency since we've agreed to postpone this edge case until after release. I'd like to do a screen-share when we meet on Tuesday though, just for sanity.

@sgpearse sgpearse self-requested a review September 12, 2023 17:09
@sgpearse sgpearse merged commit cc9d1b1 into main Sep 18, 2023
@StasJ StasJ deleted the issue3440 branch July 17, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving domain bug
2 participants