-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add calls to CCPP-compliant physics, cleanup and optimize 2018/08/17 #123
Merged
climbfuji
merged 8 commits into
NCAR:master
from
climbfuji:NEMSfv3gfs_add_teal_colored_schemes_cleanup_and_optimize_20180817
Aug 20, 2018
Merged
Add calls to CCPP-compliant physics, cleanup and optimize 2018/08/17 #123
climbfuji
merged 8 commits into
NCAR:master
from
climbfuji:NEMSfv3gfs_add_teal_colored_schemes_cleanup_and_optimize_20180817
Aug 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_prs_fv3, sfc_sice, sfc_diag, rayleigh_damp, get_phi_fv3, zhaocarr_precpd, sfc_sice_post; remove ozphys_post
…set, get_prs_fv3, sfc_sice, sfc_diag, rayleigh_damp, get_phi_fv3, sfc_sice_post; remove ozphys_post
…eset, get_prs_fv3, sfc_sice, sfc_diag, rayleigh_damp, get_phi_fv3, sfc_sice_post; remove ozphys_post
…t, get_prs_fv3, sfc_sice, sfc_diag, rayleigh_damp, get_phi_fv3, sfc_sice_post; remove ozphys_post
…eset, rename GFS_suite_update_stateout to GFS_suite_stateout_update, remove sfc_sice_pre, remove ozphys_post, remove second (misplaced) call to sfc_diag
…FS_suite_stateout_reset, rename GFS_suite_update_stateout to GFS_suite_stateout_update, remove sfc_sice_pre, remove ozphys_post, remove second (misplaced) call to sfc_diag
…i}_fv3, precpd, rayleigh_damp, sfc_diag, sfc_sice
This was referenced Aug 18, 2018
climbfuji
added
do not merge
work in progress
and removed
do not merge
work in progress
labels
Aug 18, 2018
grantfirl
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward changes. Approved.
climbfuji
deleted the
NEMSfv3gfs_add_teal_colored_schemes_cleanup_and_optimize_20180817
branch
August 20, 2018 15:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/NCAR/FV3/pull/57 for a description.