scripts/mkstatic.py: always copy data in, independent of the intent #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
requested review from
gold2718,
grantfirl and
llpcarson
as code owners
This was referenced Apr 26, 2021
gold2718
approved these changes
Apr 26, 2021
llpcarson
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because physics schemes do not know the size of each dimension of a variable allocated by the host model, we need to always copy data in when data is converted from blocked data structures into contiguous arrays.
A discussion of the meaning of
intent(out)for a physics scheme will be held at the ccpp-framework developer meeting on 04/27/2021.Associated PRs:
#368
NCAR/ccpp-physics#641
NOAA-EMC/fv3atm#291
ufs-community/ufs-weather-model#541
For regression testing, see ufs-community/ufs-weather-model#541