Update main from feature/capgen 11/09/2021 (stricter checking of units in CCPP metadata), update CODEOWNERS - requires Python 3.6 or newer #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parse_tools/parse_checkers.py for merging to feature/capgen
…_main_20210818 Update feature/capgen from main 2021/08.18
Convert framework options to DDT with methods (runtime environment).
Convert shebangs to python3
Change ccpp_error_flag to ccpp_error_code
Add polymorphic variable property
Remove optional variable property
Introduct FortranVar to allow Fortran to have undocumented optional
variables
Cleanup ccpp_error_code usage
Fix hang in datatable write plus catch more bad units
Split var_props.py from metavar.py to allow independent development
Added VarCompatObject to hold compatibility and transform information
about a pair of Var objects. This object looks for compatible
differences in units, kind, or dimensions.
Created unit tests for variable compatibility.
Move PrettyElementTree to xml_tools
Refactor ccpp_suite to separate out SuiteObjects
Created <root>/test/run_tests.sh to run all capgen tests.
Refactor capgen branch
Co-authored-by: goldy <github@goldy.online>
…code changes, and add _
…re_capgen_20211102 Fix CI test failures in feature/capgen, address pylint warnings
…pgen_20211105 Merge main into feature capgen 2021/11/05
This was referenced Nov 10, 2021
climbfuji
changed the title
|
@grantfirl for some reason I can't add you as reviewer to this PR. Maybe you didn't exist or were caught in a space-time bubble while transferring from NCAR to NOAA. |
climbfuji
changed the title
|
Regression testing complete, will merge now. |
DusanJovic-NOAA
pushed a commit
to ufs-community/ufs-weather-model
that referenced
this pull request
Nov 24, 2021
…CCPP metadata in fv3atm and ccpp-physics, use Python 3.6+ (#907) With the metadata parser update in NCAR/ccpp-framework#415, a stricter checking of units will be enforced. This includes the replacement of "convenience units" such as log(Pa) with 1. Corresponding changes are made in ccpp-physics and fv3atm. The ccpp-framework update requires Python 3.6 or newer - load Python 3.7.9 modules on Cheyenne, all other platforms are already using 3.6 or newer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update main from feature/capgen as of 11/09/2021. The feature/capgen branch contains major refactoring of the
capgen.pyscripts, including the metadata used by the currentccpp_prebuild.pyin the UFS.Except for a stricter checking of units in the CCPP metadata, these updates have no effect on the UFS or the parameterizations in the NCAR ccpp-physics main repository.
Note. The framework updates contain formatted string statements that require Python 3.6 or newer.
User interface changes?: No
Fixes #416
Last-minute change w/o effect on the code whatsoever: add @mkavulich to CODEOWNERS
Associated PRs
#415
NCAR/ccpp-physics#775
NOAA-EMC/fv3atm#422
ufs-community/ufs-weather-model#907
Testing
See ufs-community/ufs-weather-model#907