Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong units for several LSM-related variables #300

Closed
grantfirl opened this issue Aug 20, 2019 · 1 comment
Closed

Wrong units for several LSM-related variables #300

grantfirl opened this issue Aug 20, 2019 · 1 comment

Comments

@grantfirl
Copy link
Collaborator

The following LSM-related variables appear to have the wrong units in the CCPP metadata:

  • soil_moisture_content (listed as kg m-2, but is actually m when used in the CCPP; i.e. it has not been multiplied by the density of water yet)
  • total_runoff (same situation as soil_moisture_content)
  • surface_runoff (same situation as soil_moisture_content)
  • subsurface_runoff_flux (listed as g m-2 s-1, but are actually in mm s-1, or kg m-2 s-1 equivalent after conversion to m and multiplication by the density of water)
  • surface_runoff_flux (same situation as subsurface_runoff_flux)

The first 3 variables are output in FV3 from GFS_diagnostics.F90 and use a "conversion factor" of 1000 (which I'm interpreting as the density of water in kg m-3, but one could interpret it as just a number, but either way it affects the units).

There are at least 2 solutions for the first 3 variables:

  1. modify the units within the CCPP metadata to reflect their actual units (not those that are output after a conversion factor)
  2. remove the conversion factor in GFS_diagnostics

Solution 1 would necessitate using non-canonical units for the quantities, but would only require changes to the metadata. Solution 2 would require a change to the FV3 source code but the CCPP could then use the expected, canonical units for these variables (preferred).

For the runoff fluxes, only a metadata change should take place for Noah and NoahMP. The RUC LSM will need to convert to the new units since it had been coded to use the "wrong" units in the CCPP.

@climbfuji
Copy link
Collaborator

This was fixed with #307 and #308.

hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this issue Aug 3, 2022
…pp-physics (NCAR#300)

- renames the ccpp-framework and ccpp-physics branches from master to main in .gitmodules
- updates the submodule pointer for ccpp-physics for several small changes described in NCAR#658
- updates the submodule pointer for ccpp-framework for a small update described in NCAR/ccpp-framework#372
- add missing Intel DEBUG flags specific to CCPP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants