Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug without consequences in call to gwpds.f from cires_ugwp.F90 #494

Closed
climbfuji opened this issue Aug 29, 2020 · 1 comment
Closed

Bug without consequences in call to gwpds.f from cires_ugwp.F90 #494

climbfuji opened this issue Aug 29, 2020 · 1 comment

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Aug 29, 2020

The crooked way of calling gwdps_run from cires_ugwp_run, i.e. from a different CCPP scheme, contains a bug that fortunately doesn't have any consequences.

In cires_ugwp_run, we are passing the entire qgrs array with dimension (im,km,ntrac) to gwpds_run. gwpds_run, however, only expects a 2D array for specific humidity of size (im,km). This works by chance, because specific humidity is stored in the first slice of qgrs, i.e. in qgrs(:,:,1).

Thanks to @mdtoy for finding and reporting the bug.

@climbfuji
Copy link
Collaborator Author

Fixed in #483.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant