Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependencies to metadata #483

Merged
merged 24 commits into from
Sep 2, 2020
Merged

Add dependencies to metadata #483

merged 24 commits into from
Sep 2, 2020

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Aug 4, 2020 •
edited
Loading

This PR adds dependency information to CCPP schemes, see NCAR/ccpp-framework#308 and NCAR/ccpp-framework#317 for details.

Changes in this PR:

  • add [ccpp-table-properties] section for every CCPP scheme in metadata files, add dependencies
  • remove empty [ccpp-arg-table] sections from all metadata files
  • fix bug in call to gwpds_run from cires_ugwp_run, see issue Bug without consequences in call to gwpds.f from cires_ugwp.F90 #494 (unrelated to CCPP dependencies and with no impact on results)
  • number of threads used in sfcsub.F is now coming in via the argument list, delete num_parthds.F
  • update GFS_debug.F90 in preparation for adding further capabilities; the version in this PR was tested manually
  • update/cleanup of RRTMGP sampling code (from @dustinswales)

Associated PRs:
earth-system-radiation/rte-rrtmgp#85
NCAR/ccpp-framework#317
#483
NOAA-EMC/fv3atm#153
ufs-community/ufs-weather-model#180

See ufs-community/ufs-weather-model#180 for regression testing.

This was referenced Aug 4, 2020
Merged
Merged
Merged
@climbfuji climbfuji mentioned this pull request Aug 7, 2020
Merged
@climbfuji climbfuji marked this pull request as ready for review August 12, 2020 20:38
@climbfuji
Merge branch 'cleanup_sampling' of https://github.com/dustinswales/cc…
2dc3b9e 
…pp-physics into metadata_dependencies
@climbfuji
Update dependencies for physics/rrtmgp_lw_cloud_sampling.meta and phy…
767f9b5 
…sics/rrtmgp_sw_cloud_sampling.meta
@climbfuji
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into me…
a4e8f94 
…tadata_dependencies
@climbfuji
Update submodule pointer for RTE-RRTMGP
ea71b1f
@climbfuji
physics/cires_ugwp.F90: fix bug in call to gwdps_run
c85072f
@climbfuji
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into me…
a58aaec 
…tadata_dependencies
@climbfuji
Number of threads used in sfcsub.F is now coming in via the argument …
e2d663f 
…list
@climbfuji
Update GFS_debug.F90 to prepare for further debugging capabilities, a…
096ce3a 
…dd more inline documentation
@climbfuji
Copy link
Collaborator Author

Everyone, please review this PR when you get a chance, we want to merge September 2, if possible. Note that you can skip over basically all of the .meta files (112 out of the 128 changed files). Maybe look at one or two to see what the new dependencies are doing. Note that I will be sending out an update via email to EMC, GSL and other developers on how to use/develop with these changes. Thanks!

llpcarson
llpcarson approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, relying on the tests to confirm (vs code inspection!)

SMoorthi-emc
SMoorthi-emc approved these changes Sep 1, 2020
View reviewed changes
Copy link
Collaborator

@SMoorthi-emc SMoorthi-emc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand how one uses GFS_debug.F90. May be one day Dom will give a demonstration.

@climbfuji
Copy link
Collaborator Author

I am not sure I understand how one uses GFS_debug.F90. May be one day Dom will give a demonstration.

For sure I will - thanks for reviewing!

grantfirl
grantfirl approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metadata changes look as expected. The RRTMGP sampling changes are unfamiliar and not described in the PR description, but if they've been approved by @dustinswales and they pass the RTs, I'm OK with them.

@climbfuji
Copy link
Collaborator Author

The metadata changes look as expected. The RRTMGP sampling changes are unfamiliar and not described in the PR description, but if they've been approved by @dustinswales and they pass the RTs, I'm OK with them.

I am sorry, that was an oversight. The RRTMGP sampling update / cleanup is code that I received from @dustinswales directly.

@climbfuji climbfuji merged commit 0808cc2 into NCAR:master Sep 2, 2020
This was referenced Sep 2, 2020
Closed
Closed
@grantfirl grantfirl mentioned this pull request Sep 3, 2020
Merged
@climbfuji climbfuji deleted the metadata_dependencies branch June 27, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoorthi-emc SMoorthi-emc SMoorthi-emc approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@grantfirl grantfirl grantfirl approved these changes

@llpcarson llpcarson llpcarson approved these changes

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@climbfuji @llpcarson @grantfirl @junwang-noaa @SMoorthi-emc @dustinswales