-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies to metadata #317
Conversation
…ependencies; remove unnecessary [module_name] key from arguments dictionary
@gold2718 @grantfirl @ligiabernardet @llpcarson please have a look at this attempt to implement the CCPP scheme dependencies in the metadata. @gold2718 since your version of the metadata parser |
…eme-properties] section mandatory
…-table-properties] for module and DDT tables, parse dependencies for module and DDT tables
…data header is a property table or not to scripts/metadata_table.py
It seems that this section is required, can that be added to the statement above? (e.g., 'parse required sections') |
Done. |
@grantfirl @llpcarson @gold2718 please review this PR, if possible. @ligiabernardet @JulieSchramm please also take a look for your information and future documentation updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me, relying on the tests to confirm (vs code inspection!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find anything obviously amiss. Nice job on the implementation!
@gold2718 I will need to merge this now in order to not hold back the UFS, sorry. |
@climbfuji, Sorry for not getting through this. To be honest, I do not understand the code and have been struggling to get through it. |
Thansk @gold2718 - that was my understanding, too. As long as the input (semantics) and the output (functional code) are correct, it shouldn't matter. Once we switch to |
This PR removes dependency information from the CCPP prebuild config. See NCAR/ccpp-framework#308 and NCAR/ccpp-framework#317 for details on the motivation for this change and the actual implementation. It also removes some legacy code used by the dynamic CCPP build in the past. This PR also contains the changes in #156, i.e. the completion of adding the active attribute to GFS_typedefs.F90. On top of this PR, the missing active attribute for phy_fctd is added. Additionally, gfortran-10 compiler flags are added to CCPP's CMakeLists.txt.
This PR fixes #308 for
ccpp_prebuild.py
.Changes:
[ccpp-table-properties]
name = ...
attributes for these sections cannot end with one of the predefined CCPP stages (e.g._init
)[ccpp-arg-table]
sectionsccpp_prebuild.py
'sargument
dictionary: instead ofarguments[module_name][scheme_name][subroutine_name]
, usearguments[scheme_name][subroutine_name]
; this is sufficient, because per requirementmodule_name = scheme_name
src/ccpp_types.meta
scripts/metavar.py
by changingis
to==
:Associated PRs:
earth-system-radiation/rte-rrtmgp#85
#317
NCAR/ccpp-physics#483
NOAA-EMC/fv3atm#153
ufs-community/ufs-weather-model#180
See ufs-community/ufs-weather-model#180 for regression testing.