Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CCPP table properties and dependencies to metadata files #85

Conversation

climbfuji
Copy link
Contributor

@climbfuji climbfuji commented Aug 7, 2020

This PR:

Associated PRs:
#85
NCAR/ccpp-framework#317
NCAR/ccpp-physics#483
NOAA-EMC/fv3atm#153
ufs-community/ufs-weather-model#180

See ufs-community/ufs-weather-model#180 for regression testing.

@climbfuji
Copy link
Contributor Author

@dustinswales - I targeted this PR at the dtc/ccpp branch, and it shows several changes that apparently are in dtc/ccpp-dev right now (which is used with hash 6ee0b62 in the ufs-weather-model right now). The .gitmodules file in ccpp-physics still says branch = dtc/ccpp`, which makes this confusing.

Is it ok to merge dtc/ccpp-dev into dtc/ccpp as part of this PR, together with my changes?

I will also pull in the cleanup work you sent me yesterday.

@climbfuji climbfuji marked this pull request as ready for review August 12, 2020 20:38
@dustinswales
Copy link
Contributor

dustinswales commented Aug 12, 2020

@climbfuji
Yes please merge dtc/ccpp-dev onto drtc/ccpp in rte-rrtmgp. Thank you.

@climbfuji
Copy link
Contributor Author

@dustinswales can you please review this PR? It formally updates dtc/ccpp from your dtc/ccpp-dev and adds the CCPP dependencies to the .meta files. Thanks!

@climbfuji
Copy link
Contributor Author

@dustinswales can you please review this PR? It formally updates dtc/ccpp from your dtc/ccpp-dev and adds the CCPP dependencies to the .meta files. Thanks!

Correction: since you already did the update dtc/ccpp-dev --> dtc/ccpp, it only shows the CCPP dependency updates and one "bugfix" (wrong name of routine in debug print statement).

Copy link
Contributor

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@climbfuji
These changes look good to me.

@dustinswales dustinswales merged commit 566bee9 into earth-system-radiation:dtc/ccpp Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants