-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies to CCPP metadata #180
Merged
DusanJovic-NOAA
merged 21 commits into
ufs-community:develop
from
climbfuji:metadata_dependencies
Sep 2, 2020
Merged
Add dependencies to CCPP metadata #180
DusanJovic-NOAA
merged 21 commits into
ufs-community:develop
from
climbfuji:metadata_dependencies
Sep 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2020
DusanJovic-NOAA
approved these changes
Sep 2, 2020
junwang-noaa
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the capability to specify dependencies for CCPP modules/DDTs/schemes in the scheme metadata. This allows us to remove the DDT/scheme dependency information from the CCPP prebuild config in fv3atm and only compile the dependencies and schemes that are used by the selected suite definition files. Until now, all schemes and scheme dependencies are compiled, regardless whether they are in use in any of the selected suites.
Changes in this PR:
Note: preliminary documentation for these changes is available here: https://docs.google.com/document/d/1jmGxtLk-wuU-fokEDiR_ftHxBk5mDEGvelbKTqg-8m4/edit?usp=sharing - this will be sent out to developers once the code is merged.
Issue(s) addressed
NCAR/ccpp-framework#308
Testing
Regression tests passed against existing baseline on the following systems:
tests/RegressionTests_hera.intel.log
for test 18. I noted this intests/RegressionTests_hera.intel.log
(look forDH*
and*DH
)Ready to merge!
Also ran GFSv15p2 and GFSv16beta tests on macOS with clang+gfortran, including using the updated
GFS_debug.F90
from CCPP.Dependencies
Waiting on:
earth-system-radiation/rte-rrtmgp#85
NCAR/ccpp-framework#317
NCAR/ccpp-physics#483
NOAA-EMC/fv3atm#153