Enable runs that use RRTMGP with 127 vertical levels #522
Comments
|
@climbfuji Can you pls advise of the best course of action? Should @dustinswales prepare a branch off dtc/ccpp (repo rte-rrtmgp) with the one-line change and create a PR to the dtc/ccpp branch? And then also create a PR to the master branch of ccpp-physics with submodule pointers to this new branch of rte-rrtmgp? If Dustin does that, would you be able to incorporate this change within one the upcoming commits for the ccpp-physics master and therefore the ufs-weather-model? |
|
We need the whole hierarchy of PRs, rte-rrtmgp, ccpp-physics, fv3atm, ufs-weather-model.
If we combine it with a PR from my side or someone else, then the PRs for Dustin to create depend on which repositories these PRs touch (mostly ccpp-physics, fv3atm, ufs-weather-model).
Looking at the commit queue, we could ask Shan to incorporate this change in her ccpp-physics PR #520, currently scheduled for 11/30.
… On Nov 24, 2020, at 1:22 PM, ligiabernardet ***@***.***> wrote:
@climbfuji <https://github.com/climbfuji> Can you pls advise of the best course of action? Should @dustinswales <https://github.com/dustinswales> prepare a branch off dtc/ccpp (repo rte-rrtmgp) with the one-line change and create a PR to the dtc/ccpp branch? And then also create a PR to the master branch of ccpp-physics with submodule pointers to this new branch of rte-rrtmgp? If Dustin does that, would you be able to incorporate this change within one the upcoming commits for the ccpp-physics master and therefore the ufs-weather-model?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#522 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RJQEJMU57JYLFRQKETSRQIXLANCNFSM4UBIY3OQ>.
|
|
@ligiabernardet @climbfuji |
|
That sounds like a great development. Not sure how urgent, but it would require more changes in ccpp-physics as well, right? If so, it's better to put a placeholder in the commit queue and make it a separate PR (it can also go in later and we just add the 127-level fix to Shan's PR).
… On Nov 24, 2020, at 1:36 PM, dustinswales ***@***.***> wrote:
@ligiabernardet <https://github.com/ligiabernardet> @climbfuji <https://github.com/climbfuji>
I don't know how urgent this is to get on the master, or if this is helpful, but we are nearly complete with an implementation of the GP coupled with the Thompson MP (plus some other advancements for the v16 physics). I can add include this change as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#522 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RL6JVMRHZLPXUWV7OLSRQKLZANCNFSM4UBIY3OQ>.
|
|
@dustinswales It is great to hear that you are almost done with this new development. The 127-level "fix" is needed for the RRTMGP tests that need to start asap, so if you could create that PR first, that would be very helpful. You can then follow up with a separate PR for the other improvements. |
|
@ligiabernardet @climbfuji |
|
I will let Dom advise on the code management.
…On Tue, Nov 24, 2020 at 2:34 PM dustinswales ***@***.***> wrote:
@ligiabernardet <https://github.com/ligiabernardet> @climbfuji
<https://github.com/climbfuji>
I updated the rte-rrtmgp submodule in ccpp-physics, see #523
<#523>
Do I need to make PR's for fv3atm and ufs as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#522 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7WQAUC7B2DVDX77HV6HTLSRQRFRANCNFSM4UBIY3OQ>
.
|
|
@DomHeinzeller Can you advise on the code management so we can get this fix into master? |
I am trying to get this combined with a MOM6 (coupled model) update for the ufs-weather-model after #524 is merged. |
|
@dustinswales @ligiabernardet I believe this was fixed in #530, please confirm and close the issue if my understanding is correct. |
|
@climbfuji |
|
Closed via #530. |
Description
The CCPP cannot be used to run a 127-level configuration with RRTMGP. It is expected to error out with message
array plev has values outside range. This configuration is needed for the UFS and SCM tests toward GFSv17/GEFSv13.Solution
A one-line change is needed in submodule https://github.com/earth-system-radiation/rte-rrtmgp/, in branch dtc/ccpp. Note that rte-rrtmgp is a submodule of ccpp-physics.
The change is described in earth-system-radiation/rte-rrtmgp@be10425
Alternatives
Apply the one-line change manually until the problem is resolved.
Related to
ufs-community/ufs-weather-model#300
The text was updated successfully, but these errors were encountered: