Features/ccpp compile opt update #14
Conversation
In the gfsphyics IPD_driver_cap.f90 there were two references to
"ccpp_fields_get_ptr":
https://github.com/NCAR/gmtb-gfsphysics/blob/features/ccpp/IPD_layer/IPD_driver_cap.f90
lines 246 & 309.
The subroutine is not public. I (Tim) wrapped it with an interface/module
procedure as ccpp_fields_get() so as to be able to get an int, real,
logical and pointer. We should not be calling the _ptr subroutine.
modified: IPD_layer/IPD_driver_cap.f90
… into features/ccpp
modified: IPD_layer/IPD_driver_cap.f90
… into features/ccpp Conflicts: IPD_layer/IPD_driver_cap.f90
… into features/ccpp
reduces compilation time and eliminates compile failure for Intel >17.x M modified: makefile
|
Grant - this one needs to go in before we start merging... |
|
@grantfirl @llpcarson if I see this correctly, the entire commit history is already included in some way, the only commit that really changes the code is 58083a? If so, I would remove the other commits from that PR for simplicity? Or did I overlook some of the submodule stuff again? |
|
@llpcarson would a reduced optimization (-O1) still work? Should I try that today during my cheyenne / theia tests? |
|
I didn't try -O1... the routine is not computationally intensive, just assigning pointers, so no-opt is not a timing hit. |
|
@llpcarson @grantfirl I created a "clean" version of the PR also describing why we don't use/try -O1 right now, PR#18. The changes are the same. If you are ok with this, please merge it (Laurie or Grant), I think the changes themselves are fine. |
|
Replaced by PR#18. |
Workaround/bugfix for correct initialization of Thompson MP
…st_code Update to MYNN Surface Layer Scheme and related modules (NCAR#14 - based on latest code)
…o_its_own_scheme_and_z0_composite_consistent_gjf Copy FV3 changes in GFS_phys_time_vary.fv3.F90/meta to SCM versions
CCPP Scientific Documentation updates for UFS-SRW v2.1.0
Reduce optimization for GFS_diagnostics.F90:
reduces compilation time and eliminates compile failure for Intel >17.x