Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"latest GF and MYNN" #214

Merged
merged 3 commits into from
Mar 1, 2019
Merged

"latest GF and MYNN" #214

merged 3 commits into from
Mar 1, 2019

Conversation

haiqinli
Copy link
Collaborator

GF
1). introduce momentum transport to shallow convection;
2). cloud water detrainment depends on mass detrainment and in-cloud clw/ice
3). make the level with maximum cloud mass flux higher
4). update the diurnal cycle closure

MYNN
1). bug fixes of sub-grid cloud fraction

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds new files to the top-level directory of ccpp-physics, instead of updating the existing files in subdirectory physics.

@haiqinli
Copy link
Collaborator Author

I have deleted the files in op-level directory of the ccpp-physics directory, and updated the files in ccpp-physics/physics. Thanks.

@climbfuji
Copy link
Collaborator

@haiqinli Thanks very much for updating your PR. I will check out the code, run one or two tests on Theia and on my Mac to make sure that the changes don't break anything.

@climbfuji
Copy link
Collaborator

I tested those changes as follows, and they all worked.

  • compile CCPP static on MacOSX+GNU, run 24h suite_FV3_GSD test
  • run CCPP regression tests on Theia+Intel for all three modes: hybrid, standalone/dynamic, standalone/static

@haiqinli @tanyasmirnova @joeolson42 merging this now

@climbfuji climbfuji merged commit db7f73f into NCAR:gsd/develop Mar 1, 2019
@haiqinli haiqinli deleted the gsd/develop-hli branch September 24, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants