Physics Separator Merge Step2 #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding an IPD cap file so the IPD can be called by the CCPP.
* makefile update: list $(OBJS) to create the dynamic library * makefile updates for dynamic lib
adding README file for workflow testing purposes
Replace sfc_nst with sfc_nst_run. Add empty sfc_nst_init and sfc_nst_finalize. Add parseable table of sfc_nst argument descriptions. Split nstf_name argument into: nstf_name1, nstf_name4, nstf_name5. Modify call to sfc_nst in GFS_physics_driver.F90 to call sfc_nst_run. Code passes basic canned correctness tests.
No argument table or doxygen for them yet.
Pass in correct slices of variables from physics driver.
… checker scripts to run correctly
deleted: IPD_layer/IPD_driver_cap.f90 deleted: IPD_layer/scheme.xml modified: makefile
1. modified: GFS_layer/GFS_physics_driver.F90 add module use stmts for the sasas_deep module (was simple subr previously) 2. modified: physics/mfdeepcnv.f declare variables ql1 and ql2 (instead of ql(:,:,2)
climbfuji
reviewed
Dec 13, 2017
There was a problem hiding this comment.
Looks good to me, the commit history is overwhelming but as you said this includes PR#22 that needs to be merged first (will review it in a minute). Maybe it would be better to pull in the master branch into this PR once #22 is merged, then it should look cleaner?
|
Yes, that is my plan, I just wanted to get a branch and PR ready to go... will commit the first step and merge it this afternoon! |
Conflicts: GFS_layer/GFS_physics_driver.F90
|
Merged step1, so these diffs are now specific to step2 (Dave's deep convection work) |
|
Replaced by PR#24. |
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/ccpp-physics
that referenced
this pull request
May 8, 2020
…_latest_gsd_develop Merge "Updates to MYNN-EDMF NCAR#22" into gsd/develop
lisa-bengtsson
pushed a commit
to lisa-bengtsson/ccpp-physics
that referenced
this pull request
Nov 29, 2022
z0t bug fixes for NoahMP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Dave Gill,
https://github.com/davegill/gmtb-gfsphysics
branch: gfs_separator_SASS
merged with master, bit-for-bit match with baseline.
Note: this PR includes the changes from PR#22, which will be committed to master first.