Physics separation merge: Step6

[llpcarson]

From Lulin Xue,
https://github.com/lulinxue/gmtb-gfsphysics (push)

branch: GFS_separate_Noah_LSM_master_gfsphysics

merged with master, bit-for-bit match with baseline (theia)

[climbfuji]

@llpcarson @grantfirl

Is the treatment of the soil variables consistent? I just skimmed through the files, there are still assignments of the type

  Sfcprop%smc(:,:) = smsoil(:,:)
  Sfcprop%stc(:,:) = stsoil(:,:)
  Sfcprop%slc(:,:) = slsoil(:,:)

in the GFS physics driver. In the top, the original assigments are partially commented out:

•  smsoil(:,:) = Sfcprop%smc(:,:)
  

+! smsoil(:,:) = Sfcprop%smc(:,:)
stsoil(:,:) = Sfcprop%stc(:,:)

•  slsoil(:,:) = Sfcprop%slc(:,:)          !! clu: slc -> slsoil
  

+! slsoil(:,:) = Sfcprop%slc(:,:)

and the code that is commented out is now taken care of in lsm_noah_pre_run. I assume that the above lines Sfcprop%smc(:,:) = smsoil(:,:) should be in lsm_noah_post_run, or? And stsoil should be treated in the same way as smsoil and slsoil?

[grantfirl]

@llpcarson @climbfuji

Good catch, Dom. The lines
Sfcprop%smc(:,:) = smsoil(:,:) Sfcprop%slc(:,:) = slsoil(:,:)
do belong in lsm_noah_post_run.

I'm putting the lines
stsoil(:,:) = Sfcprop%stc(:,:)
and
Sfcprop%stc(:,:) = stsoil(:,:)
in GFS_surface_generic_pre and GFS_surface_generic_post due to their use in two surface schemes.

Of course, all of these lines are good candidates for code cleanup. As far as I can tell, there is no need to set smsoil, slsoil, stsoil and then assign them to Sfcprop%X since GFS_physics_driver is going away.

For the purpose of v1, though, could Laurie add the two lines setting Sfcprop%smc and slc into lsm_noah_post_run? If you don't have time to do that, I could go into your fork and do it.

[llpcarson]

Thanks for the review - I'll update this in my fork and retest... Laurie

…

On Wed, Dec 20, 2017 at 10:19 AM, grantfirl ***@***.***> wrote: @llpcarson <https://github.com/llpcarson> @climbfuji <https://github.com/climbfuji> Good catch, Dom. The lines Sfcprop%smc(:,:) = smsoil(:,:) Sfcprop%slc(:,:) = slsoil(:,:) do belong in lsm_noah_post_run. I'm putting the lines stsoil(:,:) = Sfcprop%stc(:,:) and Sfcprop%stc(:,:) = stsoil(:,:) in GFS_surface_generic_pre and GFS_surface_generic_post due to their use in two surface schemes. Of course, all of these lines are good candidates for code cleanup. As far as I can tell, there is no need to set smsoil, slsoil, stsoil and then assign them to Sfcprop%X since GFS_physics_driver is going away. For the purpose of v1, though, could Laurie add the two lines setting Sfcprop%smc and slc into lsm_noah_post_run? If you don't have time to do that, I could go into your fork and do it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#28 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHTrIvCUTuNhD4JO-h7XcG7p1bjI39-vks5tCUGOgaJpZM4RHtW-> .

[llpcarson]

I made the suggested changes, re-ran the test (theia). Please review - I'm not as fluent in this part of the physics variables as others (Grant, Dom!)

[grantfirl]

Looks good to me, Laurie.