ccpp_prebuild: out-of-source builds for parallel cmake builds (target master) #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Associated PRs: NCAR/ccpp-framework#218 (previously branches "cmake_rt_gnu_and_ccpp" of gerrit:FV3 and gerrit:NEMSfv3gfs, but these are now out of date) |
…ired for parallel cmake builds in NEMSfv3gfs
climbfuji
force-pushed
the
ccpp_prebuild_out_of_source_build
branch
from
db4b64c to
325f9b1
Compare
climbfuji
changed the title
|
This PR is no longer required, however we should keep it for further reference. The changes for the CCPP out of source build are now contained in ufs-community/ufs-weather-model#1 and associated PRs. The changes specific to the cmake_rt approach need to be consolidated with the new cmake version that EMC is working on (based on their separate ongoing efforts) and merged into the new fv3atm and ufs-weather-model repositories. |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
Features:
- Implemented sharing of atmospheric tracer metadata (name, units) to coupled model component via a standard NUOPC connector if coupling tracer field is accessed by shared memory reference
- Introduced additional metadata to tracer records in field_table to identify and validate prognostic and diagnostic chemistry tracers. A new record line starting with the `tracer_usage` keyword is now required to recognize chemistry tracer as follows:
"tracer_usage", "chemistry" (default, prognostic)
"tracer_usage", "chemistry", "type=diagnostic" (diagnostic)
- Added sanity check for input chemistry tracers, ensuring that both prognostic and diagnostic tracers in field_table are contiguous, and diagnostic tracers follow prognostic ones.
- Improved algorithm to set aerosol scavenging factors
- Exported instantaneous fields for:
- 3D non-convective liquid and ice precipitation fluxes
- 3D cloud fraction
- normalized soil wetness
- ice fraction (as used in the atmospheric model)
- lake fraction
- ocean fraction
- surface snow area fraction
- Enabled import of diagnostic tracers
Fixes:
- Prevent a divide by zero error when constant arrays are rescaled for lossy compression in `write_netcdf_parallel()`
- Correctly sample and compute elapsed time for field bundle regridding operations.
- Include hotfix (see PR NCAR#308) to allow latest `setup_exportdata()` to work with coupled chemistry.
Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications of CMakeLists.txt to support out-of-source builds, required for parallel cmake builds in NEMSfv3gfs.
Backward compatible for in-source builds for both static and dynamic builds.