-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gmtb/develop with GFSv16 changes from IPD 2019/10/06 #330
Merged
climbfuji
merged 12 commits into
NCAR:gmtb/develop
from
climbfuji:update_gmtb_develop_with_vlab_master_20191006
Oct 11, 2019
Merged
Update gmtb/develop with GFSv16 changes from IPD 2019/10/06 #330
climbfuji
merged 12 commits into
NCAR:gmtb/develop
from
climbfuji:update_gmtb_develop_with_vlab_master_20191006
Oct 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changed by commenting out print of Sfcprop%hprim and replacing replace Sfcprop%hprim variable by Sfcprop%hprime(:,1) in rrtmg routines
….F90: follow-up commit to ab96404 to update changes to new metadata format
…te with final changes to IPD GFSv16 physics
…heme GFS_surface_composites_inter that needs to run after dcyc2t3 and before the surface (land, ocean, ice) schemes
…tic output variables
…land for surface lw emissivity and total sky surface downward longwave flux absorbed by the ground
…signments over land/ocean in GFS_surface_composites_post_run
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
October 10, 2019 22:20
grantfirl
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve with same sentiments.
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
* Use NUOPC semantic labels in fv3cap. * Refactor ModelAdvance to call Model_Advance_phase1/2 * Remove ESMF_VERSION_MAJOR ifdef test. fv3atm now requires ESMF v8+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated PRs:
https://github.com/NCAR/NEMSfv3gfs/pull/261
#330
https://github.com/NCAR/FV3/pull/213
NCAR/GFDL_atmos_cubed_sphere#4
See https://github.com/NCAR/NEMSfv3gfs/pull/261 for regression testing info.
Changes for ccpp-physics: mirror GFSv16 changes for IPD
GDS_surface_composites_inter
that is called in the same place in the SDF asGDS_surface_composites_pre
used to beGDS_surface_composites_pre
now called beforedcyc2
gwdps
scheme now called internally fromcires_ugwp
scheme based on runtime configurable flags (model namelist)lgocart
logic