Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gmtb/develop with GFSv16 changes from IPD 2019/10/06 #330

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 7, 2019

Associated PRs:

https://github.com/NCAR/NEMSfv3gfs/pull/261
#330
https://github.com/NCAR/FV3/pull/213
NCAR/GFDL_atmos_cubed_sphere#4

See https://github.com/NCAR/NEMSfv3gfs/pull/261 for regression testing info.

Changes for ccpp-physics: mirror GFSv16 changes for IPD

  • requires new interstitial scheme GDS_surface_composites_inter that is called in the same place in the SDF as GDS_surface_composites_pre used to be
  • GDS_surface_composites_pre now called before dcyc2
  • gwdps scheme now called internally from cires_ugwp scheme based on runtime configurable flags (model namelist)
  • completely remove lgocart logic

SMoorthi-emc and others added 12 commits October 7, 2019 10:41
… changed by commenting out print of Sfcprop%hprim and replacing replace Sfcprop%hprim variable by Sfcprop%hprime(:,1) in rrtmg routines
….F90: follow-up commit to ab96404 to update changes to new metadata format
…heme GFS_surface_composites_inter that needs to run after dcyc2t3 and before the surface (land, ocean, ice) schemes
…land for surface lw emissivity and total sky surface downward longwave flux absorbed by the ground
…signments over land/ocean in GFS_surface_composites_post_run
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with same sentiments.

@climbfuji climbfuji merged commit 36d2070 into NCAR:gmtb/develop Oct 11, 2019
@climbfuji climbfuji deleted the update_gmtb_develop_with_vlab_master_20191006 branch June 27, 2022 03:28
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
* Use NUOPC semantic labels in fv3cap.
* Refactor ModelAdvance to call Model_Advance_phase1/2
* Remove ESMF_VERSION_MAJOR ifdef test. fv3atm now requires ESMF v8+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants