-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ccpp compliancy after merge step1 #34
Ccpp compliancy after merge step1 #34
Conversation
…rguments in argument tables, missing 'end subroutine XYZ' statements, case-sensitivity of subroutine names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subroutines calwxt/calwxt_ramer/calwxt_bourg/calwxt_revised/calwxt_explicit/calwxt_dominant and function xmytw are internal routines of GFS_calpreciptype.f90. But it does not hurt to make them CCPP-compaliant..
@mzhangw that's right, some of them are internal routines, but I think it is good manner and coding style, and since I was already working on the routines in that file ... |
I will not hurt to make the internal routines CCPP compliant, but let's
focus the energy on fixing the "standard names" and any other issues needed
to start testing with the SDF. Can't wait to see how that will turn out!
…On Wed, Dec 27, 2017 at 10:52 AM, Dom Heinzeller ***@***.***> wrote:
@mzhangw <https://github.com/mzhangw> that's right, some of them are
internal routines, but I think it is good manner and coding style, and
since I was already working on the routines in that file ...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT9oAnRVDSL_TlcFedf924eRPnFr5qQ5ks5tEoPYgaJpZM4RNrhF>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all plyr/plvl and t/q..... in radiation related codes, they are different from other physics in unit (p)and vertical dimension. In RRTMG interstitial code I named them XXX_for_radiation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep it move first
Option to roll back Thompson MP to WRFv3.8.1 (RAPv5/HRRRv4), add stochastic perturbations code
RRTMGP refactoring
RRTMGP refactoring
This PR addresses a first round of issues of the merged, separated physics schemes with regards to CCPP-compliancy: