CIRES UGWP namelist fix #343
Conversation
grantfirl
requested review from
climbfuji,
JulieSchramm and
llpcarson
as code owners
|
I have no problem with this change but not sure if it will require to rerun RTs. Thanks @grantfirl for cleaning up VAY's code. |
|
@climbfuji This passed the full rt.conf RTs using the code from ufs-community/ufs-weather-model#1 . This PR is targeted into gmtb/develop and includes the latest master, which is why it looks more substantial than it is. My changes are only commits 0eed003 and c1f1a67. Let me know if I need to change the target or what needs to happen code management-wise. Were you going to start a dtc/develop branch from the current master that should be the target? |
|
@grantfirl I am waiting for Jun to push the "merge" button for the last PR ufs-community/ufs-weather-model#1 (all dependent PRs have been merged). Once this is done, I will bring back all the changes to gmtb/develop and create the new dtc/develop branch. Then we can point your PR to this new branch and hopefully only see the two commits. Makes sense? |
Yes. FYI, I'm going to re-test the GWD interstitial reorg using this same codebase. |
There was a problem hiding this comment.
Approved but needs to be tested with ufs-weather-model. See NCAR/ccpp-scm#136 for more information
@climbfuji It was tested with ufs-weather-model, see rt_full.log in comments above. Is this not sufficient to merge? |
Sorry, I didn't see this. I think all it takes now is to also test #350 with the ufs-weather-model (just rt.conf on hera/intel) and we should be ok to merge #350, #343 (this could be merged earlier), and NCAR/ccpp-scm#136. |
use the namelist filename passed in to cires_ugwp_module.F90 rather than hard-coded input.nml