Bugfix for levr<levs, update of gcycle.F90/sfcsub.F for coupled model (Sm mar032020) #404
Conversation
… Whole Atmosphere Model
SMoorthi-emc
requested review from
climbfuji,
grantfirl,
JulieSchramm and
llpcarson
as code owners
There was a problem hiding this comment.
This all makes sense to me, as far as I can tell (I don't understand every change you are making in sfcsub.F). But I am wondering if we could skip the change of standard names (time_step -> timestep). Otherwise we'll have to make the same change in FV3 as well. I'd also like to have @grantfirl's opinion, because he is the master in composing standard names.
|
Hi Dom, |
To chime in here, Moorthi, we have been using CF conventions whenever possible: http://cfconventions.org/Data/cf-standard-names/72/build/cf-standard-name-table.html However, there is no variable with either "time step", "time-step", or "timestep" included in those conventions. This is also unfortunately one of those words that I don't think has been officially made into a compound word yet (most dictionaries don't have an entry for it), but it is just a matter of time, IMO. So, it is up to us to decide what we want to do and we should just be consistent across the CCPP. My vote is for "timestep" since every one in the modeling community will know what we mean and it has one less character. There is a ton of cleanup that could be done with CCPP standard names, and this is definitely something that is contributing toward user-unfriendliness at the moment. We have vague plans to do such a cleanup and to provide a search tool and "official" standard name guidelines for new variables for users, although I'm not sure where this task falls on the priority list right now. |
|
Thanks Grant, some day all will be cleaned up.
Moorthi
…On 3/11/20 1:09 PM, grantfirl wrote:
This all makes sense to me, as far as I can tell (I don't
understand every change you are making in sfcsub.F). But I am
wondering if we could skip the change of standard names (time_step
-> timestep). Otherwise we'll have to make the same change in FV3
as well. I'd also like to have @grantfirl
<https://github.com/grantfirl>'s opinion, because he is the master
in composing standard names.
To chime in here, Moorthi, we have been using CF conventions whenever
possible:
http://cfconventions.org/Data/cf-standard-names/72/build/cf-standard-name-table.html
However, there is no variable with either "time step", "time-step", or
"timestep" included in those conventions. This is also unfortunately
one of those words that I don't think has been officially made into a
compound word yet (most dictionaries don't have an entry for it), but
it is just a matter of time, IMO. *So, it is up to us to decide what
we want to do and we should just be consistent across the CCPP. My
vote is for "timestep" since every one in the modeling community will
know what we mean and it has one less character.*
There is a ton of cleanup that could be done with CCPP standard names,
and this is definitely something that is contributing toward
user-unfriendliness at the moment. We have vague plans to do such a
cleanup and to provide a search tool and "official" standard name
guidelines for new variables for users, although I'm not sure where
this task falls on the priority list right now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#404 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYT3FU745AQIOLB7JZDRG7AVZANCNFSM4LFGODMA>.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel:(301)683-3718
|
|
@SMoorthi-emc just to make sure, there is no change needed on the fv3atm side (or any other submodule/repository)? Thanks! |
|
You are correct. |
This is good enough, thanks. We'll drop the IPD-CCPP REPRO comparison then. |
climbfuji
changed the title
* remove unused coupled suites * delete v15p2 coupled suites * update filename when the output time is not integer hours * fix the diag time issue with output_fh Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
Hi Dom et. al,
I fixed a few bugs in the ".meta" files that would cause crash when "levr < levs".
This fix is needed for the Whole Atmosphere Model, where levs=149 but levr could be ~ 75.
While I haven't tried to run the model with 149 layers, I tried running 64 layer model with levr=63 and it crashed and that led to this fix. It should have no impact when levr=levs.
Thanks
Moorthi