-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dtc/develop from master 2020/07/07 #468
Merged
climbfuji
merged 145 commits into
NCAR:dtc/develop
from
climbfuji:update_dtc_develop_from_master_20200707
Jul 8, 2020
Merged
Update dtc/develop from master 2020/07/07 #468
climbfuji
merged 145 commits into
NCAR:dtc/develop
from
climbfuji:update_dtc_develop_from_master_20200707
Jul 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…physics timestep for first nhfrad timesteps
…cs_timestep_for_spinup Add capability to call radiation on physics timestep for first N time steps
… concentrations, calculate effective radii before first call of radiation
…ion to default values for Thompson MP
Thompson init update
Bugfix for bit-for-bit identical restart runs
… and physics/moninedmf.f
…ead of lookup tables
gsd/develop: update from master 2020/01/27
Thompson MP, MYNN pbl and GF convection: 1. Switch the order of calls, first MYNNrad_pre (or SGSCloud_RadPre), then rrtmg_pre. This will add sub-grid clouds from MYNN PBL (or MYNN PBL and GF) to QC and QI, and these updated hydrometeors will be used to compute cloud paths and effective radii. 2. In rrtmg_pre with the use of THompson MP: - use Thompson's subroutines make_IceNumber and make_DropletNumber to compute number concentrations for subgrid clouds. - use calc_effectRad to compute effective radii for QC and QI with sub-grid clouds. - added option (clduni) to use the same subroutine to compute water paths as with the GFDL MP. For this input.nl should set effr_in=.true. - the progcld5 is used mostly to compute Xu-Randall cloud fraction. 3. Added *SGSCloud_* modules to replace *MYNNrad* to add all subgrid clouds to QC and QI (from MYNN PBL and GF conv). 4. Added convective clouds qci_conv to GF scheme and SGSCloud_RadPre. 5. Computation of total cloud fraction in progcld5 is change not to depend on shallow/deep convection. Not needed in the current version of GSD suite.
…into gsd-dev-clouds
2. Bug fix for the case when GF scheme is used without MYNN. In this case always use Xu-Randall cloud fraction.
…s, implement model/ccpp/total tendencies.
updating fork
…ter_20200616 Update gsd/develop from master 2020/06/16
Mods to MYNN sfc and PBL for fractional/coupled for latest gsd/develop code (based on NCAR#40)
updating fork
Updates to module_SGSCloud_RadPre.F90 and .meta (from Tanya)
…elop_20200630 Update master from gsd/develop 2020/06/30
Fixes to run the CCPP multi_gases option with 32 bit
This was referenced Jul 7, 2020
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
July 7, 2020 16:55
llpcarson
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's alot of changes! Approved based on testing results, and a quick-look at the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dtc/develop from master, which contains:
Associated PRs:
NCAR/ufs-weather-model#59
NCAR/fv3atm#58
#468
NCAR/ccpp-framework#310
NCAR/GFDL_atmos_cubed_sphere#15
For regression testing information, see NCAR/ufs-weather-model#59