-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/transition-to-capgen-1: update from master 2020/10/02, change horizontal_dimension to horizontal_loop_extent, fix legacy warnings #504
Merged
climbfuji
merged 21 commits into
NCAR:feature/transition-to-capgen-1
from
climbfuji:update_from_master_20201002_and_more
Oct 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, merge get_alpha from RRTMG with get_alpha_exp from RRTMGP
…NPBL_wrapper.F90, ysuvdif.F90, shinhongvdif.F90
…en't already doing so
… diagnostic calculation outside of loops
… of meta files in ccpp-physics
…cono_cloud_overlap_merged_with_rrtmgp_and_updated
…d_with_rrtmgp_and_updated RRTMG cloud overlap method update (contains NCAR#477)
fix diagnostic PBL and convective tendencies
…into update_from_master_20201002_and_more
…tines without entries in the metadata files
climbfuji
changed the title
feature/transition-to-capgen-1: update from master 2020/10/02, change horizontal_dimension to horizontal_loop_extent
feature/transition-to-capgen-1: update from master 2020/10/02, change horizontal_dimension to horizontal_loop_extent, fix legacy warnings
Oct 5, 2020
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
October 5, 2020 17:07
XiaSun-Atmos
approved these changes
Oct 5, 2020
grantfirl
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
horizontal_dimension
tohorizontal_loop_extent
and vice versa inphysics/*.meta
filesAssociated PRs:
NCAR/ccpp-framework#326
#504
NCAR/fv3atm#63
NCAR/ufs-weather-model#64
For regression testing information, see NCAR/ufs-weather-model#64.