Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addendum to #614 (fix conditionally allocated array issue) #652

Merged
merged 2 commits into from
May 18, 2021

Conversation

grantfirl
Copy link
Collaborator

  • change 'htrlwu' variable to assumed-shape since it is conditionally allocated to avoid seg faults with GNU/release in SCM

Fixes #651

@climbfuji
Copy link
Collaborator

It seems that PR #611 did not capture all arrays with explicit dimensions, please change all explicit dimensions in that file (and any others you come across) to assumed sizes, not just the one array.

@grantfirl
Copy link
Collaborator Author

It seems that PR #611 did not capture all arrays with explicit dimensions, please change all explicit dimensions in that file (and any others you come across) to assumed sizes, not just the one array.

@climbfuji Done. I didn't do a systematic check to see if other files were missing the assumed-shape changes, since that was beyond the scope of this PR (to fix seg faults with the GNU compiler in SCM).

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @grantfirl, for making the additional changes - looks good. Will approve when the regression tests have been done with the UFS.

@grantfirl
Copy link
Collaborator Author

OK, I hope the UFS tests pass. It compiled/ran OK in the SCM at least.

@climbfuji
Copy link
Collaborator

I know why the parser didn't catch it, it first looks for invalid type definitions in each file (they are not invalid, just something isn't as capgen wants it), and if this test fails it doesn't parse the dimensions. There might be a few RRTMGP files that need checking, as well as GFS_debug.F90. I'll look at those.

climbfuji added a commit that referenced this pull request May 18, 2021
@climbfuji climbfuji merged commit 36486c3 into NCAR:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditionally-allocated array not given assumed-shape in GFS_suite_interstitial.F90
2 participants