Update rrtmg radiation code from NEMSfv3gfs #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add two new entries in the "clouds" array (diagnositc output only?)
2. surface perturbations
3. Re-order a few if-tests in radlw_main.f
modified: GFS_layer/GFS_radiation_driver.F90
modified: physics/radiation_clouds.f
modified: physics/radiation_surface.f
modified: physics/radlw_main.f
modified: physics/radsw_main.f
|
Code compiles OK, just starting to run some tests now. The long names for the new vars are likely not physically correct - not well described/documented in the code! PR for FV3 is #8: https://github.com/NCAR/FV3/pull/8 |
climbfuji
reviewed
Jun 13, 2018
GFS_layer/GFS_radiation_driver.F90
Outdated
| @@ -1290,6 +1291,7 @@ subroutine GFS_radiation_driver & | |||
| cld_iwp=clouds(:,:,4), cld_ref_ice=clouds(:,:,5), & | |||
| cld_rwp=clouds(:,:,6), cld_ref_rain=clouds(:,:,7), & | |||
| cld_swp=clouds(:,:,8), cld_ref_snow=clouds(:,:,9), & | |||
| cld_od_total=clouds(:,:,10), cld_od_layer w=clouds(:,:,11), & | |||
There was a problem hiding this comment.
Does this compile? what is the w doing in between cld_od_layer and =clouds(:,:,11)?
climbfuji
reviewed
Jun 13, 2018
GFS_layer/GFS_radiation_driver.F90
Outdated
| @@ -1256,6 +1256,7 @@ subroutine GFS_radiation_driver & | |||
| cld_iwp=clouds(:,:,4), cld_ref_ice=clouds(:,:,5), & | |||
| cld_rwp=clouds(:,:,6), cld_ref_rain=clouds(:,:,7), & | |||
| cld_swp=clouds(:,:,8), cld_ref_snow=clouds(:,:,9), & | |||
| cld_od_total=clouds(:,:,10), cld_od_layer w=clouds(:,:,11), & | |||
There was a problem hiding this comment.
Does this compile? what is the w doing in between cld_od_layer and =clouds(:,:,11)?
|
@llpcarson let me know when this code change is finished and ready to go in, see also my comments to one of the changes |
|
Thanks for the review, Dom. I hadn't compiled the GFS_layer part yet, when
I pushed this to github. I'm working on this this afternoon, and will
update everyone soon with the status.
…On Wed, Jun 13, 2018 at 11:22 AM, Dom Heinzeller ***@***.***> wrote:
@llpcarson <https://github.com/llpcarson> let me know when this code
change is finished and ready to go in, see also my comments to one of the
changes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHTrIni_l4BagtdssL0NYM2os25b06Xiks5t8UpQgaJpZM4Ue05L>
.
|
added 2 commits
June 13, 2018 15:21
|
This PR was superseded by #101 and the corresponding PRs to the other repositories involved. |
SamuelTrahanNOAA
added a commit
to SamuelTrahanNOAA/ccpp-physics
that referenced
this pull request
Jun 8, 2021
…n_20210531 Update gsl/develop from main 2021/05/31
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
* Merge branch 'man_hafs_sas_without_updates_of_dtc_develop_49b73a8f4149ca88f071dbaae81f1769b120f1e0' into HEAD * gfsphysics/physics/GFS_debug.F90: add capability to debug 1-d logical arrays * Clean up error messages in gfsphysics/GFS_layer/GFS_typedefs.F90 Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to radiation since the fv3 v0 release:
This PR also needs a PR from FV3, to update the dy-core metadata tables in GFS_typedefs.F90