Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert 2mtq diag method #948

Merged
merged 1 commit into from
Aug 2, 2022
Merged

revert 2mtq diag method #948

merged 1 commit into from
Aug 2, 2022

Conversation

JessicaMeixner-NOAA
Copy link

This PR its for P8.

author: @HelinWei-NOAA

@JessicaMeixner-NOAA
Copy link
Author

@HelinWei-NOAA can you provide any additional description?

This was referenced Jul 27, 2022
Merged
Merged
@HelinWei-NOAA
Copy link
Collaborator

HelinWei-NOAA commented Jul 27, 2022 •
edited
Loading

The reason we had this change in the last NoahMP update can be found here. We tried to address the high 2m Td bias over the bare soil area. From mini P8c results, this approach doesn't reduce the bias but unexpectedly increasing the magnitude of the diurnal variation of 2m T. We are testing the other approach but probably can't get it into P8c in time. So for safety we want to revert this change and the way to diagnose 2m T/Q will be the same as P8b, i.e. using sfc_diag.f instead of two-tiled values from NoahMP.

@jkbk2004
Copy link
Contributor

jkbk2004 commented Aug 2, 2022

All tests finished on ufs-wm pr#1338. Can I ask for final review and merging this PR?

@grantfirl grantfirl merged commit ee43baf into NCAR:main Aug 2, 2022
@grantfirl
Copy link
Collaborator

All tests finished on ufs-wm pr#1338. Can I ask for final review and merging this PR?

@jkbk2004 Done.

pjpegion added a commit to pjpegion/ccpp-physics that referenced this pull request Sep 21, 2022
@pjpegion
Revert "Merge pull request NCAR#948 from JessicaMeixner-NOAA/feature/p8"
0b3ceff 
This reverts commit ee43baf, reversing
changes made to 12c115e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfirl grantfirl grantfirl approved these changes

@climbfuji climbfuji Awaiting requested review from climbfuji

@SamuelTrahanNOAA SamuelTrahanNOAA Awaiting requested review from SamuelTrahanNOAA

@mzhangw mzhangw Awaiting requested review from mzhangw mzhangw is a code owner

@panll panll Awaiting requested review from panll

@mkavulich mkavulich Awaiting requested review from mkavulich

@ChunxiZhang-NOAA ChunxiZhang-NOAA Awaiting requested review from ChunxiZhang-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JessicaMeixner-NOAA @HelinWei-NOAA @jkbk2004 @grantfirl