UFS/dev PR#6 #973
Merged
UFS/dev PR#6 #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module_sf_ruclsm has comparisons to zero, which break the code when numbers are very close to 0, such as 1e-322. This happens with the gfortran compiler when compled -DDEBUG=ON since the option to truncate subnormal numbers is turned off. The workaround is to truncate subnormal numbers manually, for the two variables that cause trouble.
NCAR/main PR NCAR#967 (Bugfix and optimization of prognostic closure for the P8 physics suit)
grantfirl
requested review from
climbfuji,
SamuelTrahanNOAA,
mzhangw,
panll,
mkavulich and
ChunxiZhang-NOAA
as code owners
dustinswales
requested review from
dustinswales
and removed request for
SamuelTrahanNOAA,
mzhangw,
panll,
mkavulich and
ChunxiZhang-NOAA
dustinswales
approved these changes
Oct 18, 2022
|
@grantfirl Are there any changes to the baselines? |
Yes, according to the UFS PR: "All tests that have regional boundary conditions or use the RUC LSM may change results." |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is identical to ufs-community#6 in the ufs/dev branch. See there for a description.