Remove NCEPlibs from repo #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one Cheyenne setup script (need NCEPlibs installation that corresponds to other Cheyenne setup scripts
…pply a default, set variables for needed NCEPlibs, set STATIC to false
|
Associated PR: NCAR/ccpp-physics#258 |
grantfirl
force-pushed
the
remove_NCEPlibs
branch
from
410a7ca to
cfdfd86
Compare
climbfuji
reviewed
Jun 5, 2019
|
Tested on MacOS, Theia (all compilers), Cheyenne (all compilers). Should be good to go. Further CMakeLists.txt cleanup should be undertaken as part of addressing issue #103 (static build). |
climbfuji
approved these changes
Jun 5, 2019
dustinswales
pushed a commit
to dustinswales/ccpp-scm
that referenced
this pull request
May 16, 2022
Remove NCEPlibs from repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address Issue #59
This PR removes the copies of the NCEPlibs code and updates CMakeLists.txt to point to a local installation of NCEPlibs. CMakeLists.txt expects a NCEPLIBS_DIR environment variable to be set to the location of the installation. The Theia and Cheyenne setup scripts are modified to set this environment variable depending on the build. Instructions are added to the docs for installing NCEPlibs on a user's machine if not using Theia/Cheyenne.