RRTMGP w/ GFS SDFs #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinswales
requested review from
climbfuji,
grantfirl and
llpcarson
as code owners
grantfirl
reviewed
May 2, 2020
| @@ -8,5 +8,5 @@ | |||
| branch = dtc/develop | |||
There was a problem hiding this comment.
We'll want to see this reverted after successful testing.
|
Do these PRs "change the answer"? There are regression tests for RRTMGP in the ufs-weather-model repo. Did you run those? If these are expected to change the answer and you're happy with the change, it's fine if they don't pass, but we'll want to update the baseline. |
grantfirl
pushed a commit
to grantfirl/fv3atm
that referenced
this pull request
May 6, 2020
|
Moving PR to EMC repository |
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Sep 24, 2020
…te_20200826 Update submodule pointer for ccpp/physics 20200826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two suite definition files to be used w/ ccpp-physics, see PR NOAA-EMC#446 (NCAR/ccpp-physics#446).