Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GA-1538] Upstream CI is failing #620

Open
kafitzgerald opened this issue May 20, 2024 · 2 comments
Open

[GA-1538] Upstream CI is failing #620

kafitzgerald opened this issue May 20, 2024 · 2 comments
Labels
blocked Work got blocked waiting the output of some other source/work dependencies Pull requests that update a dependency file testing Issue related to testing

Comments

@kafitzgerald
Copy link
Contributor

Please describe your issue here

Upstream CI is failing as of a couple of days ago (first failure here), because of the use of the now deprecated np.product in eofs.

It looks like there's an open PR to address this, but it's been sitting for a bit.

@anissa111
Copy link
Member

Also want to note here that even though our upstream CI is picking this up, we have numpy<2.0 pinned, so this won't affect our regular CI or up-to-date releases.

@anissa111 anissa111 added blocked Work got blocked waiting the output of some other source/work dependencies Pull requests that update a dependency file testing Issue related to testing labels May 20, 2024
@anissa111 anissa111 changed the title [Issue]: Upstream CI is failing [GA-1538] Upstream CI is failing Sep 17, 2024
@kafitzgerald
Copy link
Contributor Author

It looks like that PR over on eofs still hasn't been merged. I wonder if we should look into using something like xeofs or generally doing something different for EOFs.

It might also be worth thinking about doing more of this via applications and deprecating the functions here. Given that deprecations (should) take some time and this seems to be the main (or maybe only) reason for the numpy version pin, it might not be a bad idea to have that discussion sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Work got blocked waiting the output of some other source/work dependencies Pull requests that update a dependency file testing Issue related to testing
Projects
None yet
Development

No branches or pull requests

2 participants