-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GA-1538] Upstream CI is failing #620
Comments
Also want to note here that even though our upstream CI is picking this up, we have numpy<2.0 pinned, so this won't affect our regular CI or up-to-date releases. |
It looks like that PR over on eofs still hasn't been merged. I wonder if we should look into using something like xeofs or generally doing something different for EOFs. It might also be worth thinking about doing more of this via applications and deprecating the functions here. Given that deprecations (should) take some time and this seems to be the main (or maybe only) reason for the numpy version pin, it might not be a bad idea to have that discussion sooner rather than later. |
Please describe your issue here
Upstream CI is failing as of a couple of days ago (first failure here), because of the use of the now deprecated np.product in eofs.
It looks like there's an open PR to address this, but it's been sitting for a bit.
The text was updated successfully, but these errors were encountered: