Address numpy DeprecationWarnings #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Zeitsperre
added a commit
to Ouranosinc/xclim
that referenced
this pull request
Jan 29, 2024
### What kind of change does this PR introduce? * Drops Python3.8 references and marks Python3.9 as base requirement. * Drops older `xarray` and `pandas` support. * Updates documentation and CI for dropped Python3.8. * Raises required versions of `scipy` and `numpy` (`1.9.0` and `1.20.0`, respectively). * Removes the `winter_storm` indice and indicator (deprecated in `xclim` v0.46.0). * Adopts the new syntax for frequency codes: - "A" is no more - Y -> YE, Q -> QE, M -> ME - H -> h, T -> min, S -> s, L -> ms, U -> us, N -> ns * Addresses several `DeprecationWarning` and `RuntimeWarning` messages related to `numpy`, `xarray`, and `pint` ### Does this PR introduce a breaking change? **Yes**, Python3.8 is no longer supported and base dependency versions have been augmented: - `numpy>=1.20.0` - `pandas>=2.2.0` - `scipy>=1.9.0` - `xarray>=2023.11.0` ### Other information: ~Python3.12 support is still not possible due to missing Python3.12 builds for `numba`. (This is being addressed in #1613)~ - This has been addressed. A Pull Request has been opened to address `DeprecationWarning`s stemming from `numpy` calls in `eofs` (ajdawson/eofs#148; `eofs` has been removed due to licensing-related issues (#1621))
This was referenced May 20, 2024
|
@ajdawson Hi, I was just wondering if there's anything else I can do to help this PR along. Thanks! |
|
@Zeitsperre on line 206 in standard.py you need to change |
|
@bbuzz31 Not sure if I understand. Do you mean to say that you'll be dropping NumPy v1.x support, so the only changes needed are for the new Edit: Ah, I understand! My bad! Will modify. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've been working to reduce warnings in a downstream project and figured I could send a PR your way to address some messages coming from here.
Changes
packaginglibrary (provides a version-parsing replacement for the deprecateddistutils, endorsed by PyPA)numpy.{prod|product}, which can be removed wheneofsdrops Python3.8 support.np.NaNartifacts withnp.nan.All the best!