-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python3.8, support Pandas v2.2, reduce Warnings #1565
Conversation
On inspection, the No further action is required. |
@aulemahal I've left a few "FIXME" notices since changes will ultimately involve us needing to make some API/UI decisions. |
Fixed! My solution also works with 2023.11.0. |
Adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
But I hereby approve the lines I did not write.
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR mixes a lot of apparently unrelated changes (formatting, the pandas freq update, deprecations, etc). Makes it hard to review.
The code still accepts "A" as an offset, I assume it's because it's still supported upstream?
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Sorry for the mammouth PR indeed. All those changes stem from the same two updates of python and pandas. Xclim doesn't precribe what frequency code should be used, in most cases, it only passes them down to xarray. This PR changes all places where xclim was using the old codes (tests, checks, documentation). A user with pandas < 3 will stil be able to use "A" and should get a warning from pandas. However, there a some instances where a frequency code is checked against the output of |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
xarray
andpandas
support.scipy
andnumpy
(1.9.0
and1.20.0
, respectively).winter_storm
indice and indicator (deprecated inxclim
v0.46.0).DeprecationWarning
andRuntimeWarning
messages related tonumpy
,xarray
, andpint
Does this PR introduce a breaking change?
Yes, Python3.8 is no longer supported and base dependency versions have been augmented:
numpy>=1.20.0
pandas>=2.2.0
scipy>=1.9.0
xarray>=2023.11.0
Other information:
Python3.12 support is still not possible due to missing Python3.12 builds for- This has been addressed.numba
. (This is being addressed in #1613)A Pull Request has been opened to address
DeprecationWarning
s stemming fromnumpy
calls ineofs
(ajdawson/eofs#148;eofs
has been removed due to licensing-related issues (#1621))