Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to implicit namespace package #563

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Feb 26, 2024

PR Summary

Closes #547, replaces #557

Summary of changes:

  • Converts geocat-comp to use an implicit namespace set up
    • removes geocat/__init__.py
    • changes to setup.cfg
  • Makes some additions to MANIFEST.in to avoid packaging everything in the top level directory (side note, might want to revisit flat vs src-layout)

NOTE: This will have to be duplicated over on geocat-viz before being included in a release on this repo (edit: see NCAR/geocat-viz#220).

Resources:

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@anissa111 anissa111 added refactor Internal code refactoring developer feature For development standardization / best practices / enhancement deprecation A feature is being deprecated or removed labels Feb 26, 2024
@anissa111 anissa111 marked this pull request as ready for review February 26, 2024 23:53
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@cyschneck cyschneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, glad to see it behaving with the readthedocs 👍

@anissa111 anissa111 merged commit 9a302c1 into NCAR:main Feb 27, 2024
15 checks passed
@anissa111 anissa111 deleted the namespace branch February 27, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation A feature is being deprecated or removed developer feature For development standardization / best practices / enhancement refactor Internal code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging updates needed for namespace packages
3 participants