Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oregonator #222

Merged
merged 16 commits into from
Sep 14, 2023
Merged

Oregonator #222

merged 16 commits into from
Sep 14, 2023

Conversation

K20shores
Copy link
Collaborator

@K20shores K20shores commented Sep 12, 2023

closes #226. Adds another test, this one is called oregonator

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Patch coverage: 73.91% and project coverage change: -0.17% ⚠️

Comparison is base (7021f00) 97.23% compared to head (ff30039) 97.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   97.23%   97.06%   -0.17%     
==========================================
  Files          32       32              
  Lines        2564     2590      +26     
==========================================
+ Hits         2493     2514      +21     
- Misses         71       76       +5     
Files Changed Coverage Δ
include/micm/process/process.hpp 88.00% <0.00%> (-12.00%) ⬇️
include/micm/solver/rosenbrock.hpp 100.00% <ø> (ø)
include/micm/solver/rosenbrock.inl 96.86% <100.00%> (+0.29%) ⬆️
include/micm/system/system.hpp 95.55% <100.00%> (+0.96%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@K20shores K20shores linked an issue Sep 13, 2023 that may be closed by this pull request
@K20shores K20shores marked this pull request as ready for review September 13, 2023 20:32
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put a couple questions on #229 that I think should have actually been on this PR instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oregonator
4 participants