Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exiting error code for compute-sanitizer #553

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

sjsprecious
Copy link
Collaborator

This PR adds a non-zero exiting code for compute-santizer when it finishes a run and detects a memory leak. Therefore, a test with memory leak will fail as expected.

fix #552

@sjsprecious sjsprecious self-assigned this Jun 5, 2024
@sjsprecious sjsprecious added the bug Something isn't working label Jun 5, 2024
@sjsprecious sjsprecious added this to the CUDA Rosenbrock Solver milestone Jun 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (555be4e) to head (595be3b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          45       45           
  Lines        3407     3407           
=======================================
  Hits         3143     3143           
  Misses        264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattldawson mattldawson merged commit 84f36e3 into main Jun 5, 2024
32 checks passed
@mattldawson mattldawson deleted the fix-compute-sanitizer-usage branch June 5, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return nonzero error when detecting memory leak on the GPU
3 participants